netdev - Re: [PATCH net-next] skbuff: kill skb_flow_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7crCkz1gV6Wz14B@boxer>
Date: Thu, 20 Feb 2025 14:15:54 +0100
From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To: Nicolas Dichtel <nicolas.dichtel@...nd.com>
CC: Simon Horman <horms@...nel.org>, "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Eric
 Dumazet" <edumazet@...gle.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] skbuff: kill skb_flow_get_ports()

On Thu, Feb 20, 2025 at 02:02:05PM +0100, Nicolas Dichtel wrote:
> Le 20/02/2025 à 11:54, Simon Horman a écrit :
> > On Tue, Feb 18, 2025 at 03:37:17PM +0100, Nicolas Dichtel wrote:
> >> This function is not used anymore.
> >>
> >> Fixes: a815bde56b15 ("net, bonding: Refactor bond_xmit_hash for use with xdp_buff")

Hi, Fixes tag is redundant as this is -next material.

> >> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> > 
> > Reviewed-by: Simon Horman <horms@...nel.org>
> > 
> > I guess the churn isn't worth it, but it seems to me that
> > __skb_flow_get_ports could be renamed skb_flow_get_ports.
> > 
> Right. I can send a follow-up patch.
> 
> 
>