netdev - Re: [PATCH net-next] skbuff: kill skb_flow_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <556b48d9-f502-4b02-9131-fbb13cd111a6@6wind.com>
Date: Thu, 20 Feb 2025 14:02:05 +0100
From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] skbuff: kill skb_flow_get_ports()

Le 20/02/2025 à 11:54, Simon Horman a écrit :
> On Tue, Feb 18, 2025 at 03:37:17PM +0100, Nicolas Dichtel wrote:
>> This function is not used anymore.
>>
>> Fixes: a815bde56b15 ("net, bonding: Refactor bond_xmit_hash for use with xdp_buff")
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> 
> I guess the churn isn't worth it, but it seems to me that
> __skb_flow_get_ports could be renamed skb_flow_get_ports.
> 
Right. I can send a follow-up patch.