netdev - Re: [PATCH net-next v2 1/7] selftests: drv-net: add a warning for bkg + shell + terminate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7eyaUB_LUET8uS8@LQ3V64L9R2>
Date: Thu, 20 Feb 2025 17:53:29 -0500
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	stfomichev@...il.com, petrm@...dia.com
Subject: Re: [PATCH net-next v2 1/7] selftests: drv-net: add a warning for
 bkg + shell + terminate

On Thu, Feb 20, 2025 at 01:10:59PM -0800, Jakub Kicinski wrote:
> On Thu, 20 Feb 2025 14:31:35 -0500 Joe Damato wrote:
> > > +        if shell and self.terminate:
> > > +            print("# Warning: combining shell and terminate is risky!")
> > > +            print("#          SIGTERM may not reach the child on zsh/ksh!")
> > > +  
> > 
> > This warning did not print on my system, FWIW. Up to you if you want
> > to respin and drop it or just leave it be.
> 
> You mean when running this patchset? It shouldn't, the current 
> test uses ksft_wait rather than terminate. The warning is for
> test developers trying to use the risky config in new tests.
> 
> > I am fine with this warning being added, although I disagree with
> > the commit message as mentioned in my previous email.
> 
> I'll edit the commit message when applying. Unless you want to dig
> deeper and find out why your bash/env is different than mine :(

No, no - no need for that much extra work. Just wanted to mention
for anyone following along or who stumbles on this in the future
that my shell is bash, is all :)

Thanks again for the work on this.