netdev - Re: [PATCH net] selftests/net: big_tcp: longer netperf session on slow machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d433a173-27cc-5ee9-4d00-133153dd44ef@redhat.com>
Date: Fri, 21 Feb 2025 11:14:11 +0100 (CET)
From: Pablo Martin Medrano <pablmart@...hat.com>
To: Paolo Abeni <pabeni@...hat.com>
cc: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, 
    "David S . Miller" <davem@...emloft.net>, 
    Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>, 
    Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH net] selftests/net: big_tcp: longer netperf session on
 slow machines

On Fri, 21 Feb 2025, Paolo Abeni wrote:
> On 2/21/25 1:54 AM, Jakub Kicinski wrote:
>> Why not increase the test duration then?
>
> I gave this guidance, as with arbitrary slow machines we would need very
> long runtime. Similarly to the packetdril tests, instead of increasing
> the allowed time, simply allow xfail on KSFT_MACHINE_SLOW.

I have resubmitted a properly versioned and tagged patch (and with the 
right title as indeed it does not increase the netperf session duration) at:

https://lore.kernel.org/netdev/23340252eb7bbc1547f5e873be7804adbd7ad092.1739983848.git.pablmart@redhat.com/

In that patch the Fixes: commit, found by Paolo, was when the duration 
moved from the netperf default (10 seconds) to 1 second. As he mentions 
even with 10 seconds it is not guaranteed that in slow systems and/or 
under load the test will not fail, hence the skip/xfail