netdev - Re: [PATCH net] selftests/net: big_tcp: longer netperf session on slow machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c36c6de0-fc01-4d8c-81e5-cbdf14936106@redhat.com>
Date: Fri, 21 Feb 2025 10:14:35 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>,
 Pablo Martin Medrano <pablmart@...hat.com>
Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>,
 Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH net] selftests/net: big_tcp: longer netperf session on
 slow machines

On 2/21/25 1:54 AM, Jakub Kicinski wrote:
> On Tue, 18 Feb 2025 17:19:28 +0100 Pablo Martin Medrano wrote:
>> After debugging the following output for big_tcp.sh on a board:
>>
>> CLI GSO | GW GRO | GW GSO | SER GRO
>> on        on       on       on      : [PASS]
>> on        off      on       off     : [PASS]
>> off       on       on       on      : [FAIL_on_link1]
>> on        on       off      on      : [FAIL_on_link1]
>>
>> Davide Caratti found that by default the test duration 1s is too short
>> in slow systems to reach the correct cwd size necessary for tcp/ip to
>> generate at least one packet bigger than 65536 (matching the iptables
>> match on length rule the test evaluates)
> 
> Why not increase the test duration then?

I gave this guidance, as with arbitrary slow machines we would need very
long runtime. Similarly to the packetdril tests, instead of increasing
the allowed time, simply allow xfail on KSFT_MACHINE_SLOW.

Cheers,

Paolo