netdev - Re: [PATCH iwl-next] igc: Change Tx mode for MQPRIO offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmdj8ydu.fsf@kurt.kurt.home>
Date: Fri, 21 Feb 2025 10:01:33 +0100
From: Kurt Kanzenbach <kurt@...utronix.de>
To: "Abdul Rahim, Faizal" <faizal.abdul.rahim@...ux.intel.com>, Tony Nguyen
 <anthony.l.nguyen@...el.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Sebastian Andrzej
 Siewior <bigeasy@...utronix.de>, intel-wired-lan@...ts.osuosl.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH iwl-next] igc: Change Tx mode for MQPRIO offloading

On Fri Feb 21 2025, Abdul Rahim, Faizal wrote:
> On 17/2/2025 7:45 pm, Kurt Kanzenbach wrote:
>> The current MQPRIO offload implementation uses the legacy TSN Tx mode. In
>> this mode the hardware uses four packet buffers and considers queue
>> priorities.
>> 
>> In order to harmonize the TAPRIO implementation with MQPRIO switch to the
> Missed "," ?
> In order to harmonize the TAPRIO implementation with MQPRIO, switch to the

Ok.

>
>> diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c b/drivers/net/ethernet/intel/igc/igc_tsn.c
>> index 1e44374ca1ffbb86e9893266c590f318984ef574..6e4582de9602db2c6667f1736cc2acaa4d4b5201 100644
>> --- a/drivers/net/ethernet/intel/igc/igc_tsn.c
>> +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c
>> @@ -47,7 +47,7 @@ static unsigned int igc_tsn_new_flags(struct igc_adapter *adapter)
>>   		new_flags |= IGC_FLAG_TSN_QAV_ENABLED;
>>   
>>   	if (adapter->strict_priority_enable)
>> -		new_flags |= IGC_FLAG_TSN_LEGACY_ENABLED;
>> +		new_flags |= IGC_FLAG_TSN_QBV_ENABLED;
>>   
>>   	return new_flags;
>>   }
>
> IGC_FLAG_TSN_QBV_ENABLED is set multiple times in different lines:
>
> 	if (adapter->taprio_offload_enable)
> 		new_flags |= IGC_FLAG_TSN_QBV_ENABLED;
>
> 	if (is_any_launchtime(adapter))
> 		new_flags |= IGC_FLAG_TSN_QBV_ENABLED;
>
> 	if (is_cbs_enabled(adapter))
> 		new_flags |= IGC_FLAG_TSN_QAV_ENABLED;
>
> 	if (adapter->strict_priority_enable)
> 		new_flags |= IGC_FLAG_TSN_QBV_ENABLED;
>
> 	return new_flags;
> }
>
> We can combine the conditions to simplify:
> 	if (adapter->taprio_offload_enable ||
>              is_any_launchtime(adapter) ||
>              adapter->strict_priority_enable)
> 		new_flags |= IGC_FLAG_TSN_QBV_ENABLED;

Sure.

Should I send a v2 or do you want to carry this patch in your next fpe
series?

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)