netdev - Re: [PATCH] net: ethernet: ti: am65-cpsw: select PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250221161613.67fe279f@kernel.org>
Date: Fri, 21 Feb 2025 16:16:13 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Sascha Hauer <s.hauer@...gutronix.de>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw: select PAGE_POOL

On Thu, 20 Feb 2025 09:43:06 +0100 Sascha Hauer wrote:
> am65-cpsw uses page_pool_dev_alloc_pages(), thus needs PAGE_POOL
> selected to avoid linker errors.

If it can actually result in linker errors today could you add a Fixes
tag pointing to the commit that added the dependency?

If it can't (perhaps one of the many already selected symbols already
implies PAGE_POOL?) could you explain in the commit msg?
-- 
pw-bot: cr