netdev - Re: [PATCH net v2 2/2] selftests: Add IPv6 link-local address generation tests for GRE devices.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z73dm4P+Ho4EiprQ@debian>
Date: Tue, 25 Feb 2025 16:11:23 +0100
From: Guillaume Nault <gnault@...hat.com>
To: Ido Schimmel <idosch@...sch.org>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	netdev@...r.kernel.org, Simon Horman <horms@...nel.org>,
	David Ahern <dsahern@...nel.org>,
	Antonio Quartulli <antonio@...delbit.com>
Subject: Re: [PATCH net v2 2/2] selftests: Add IPv6 link-local address
 generation tests for GRE devices.

On Mon, Feb 24, 2025 at 06:49:43PM +0100, Guillaume Nault wrote:
> On Sun, Feb 23, 2025 at 04:29:40PM +0200, Ido Schimmel wrote:
> > On Fri, Feb 21, 2025 at 10:24:10AM +0100, Guillaume Nault wrote:
> > > GRE devices have their special code for IPv6 link-local address
> > > generation that has been the source of several regressions in the past.
> > > 
> > > Add selftest to check that all gre, ip6gre, gretap and ip6gretap get an
> > > IPv6 link-link local address in accordance with the
> > > net.ipv6.conf.<dev>.addr_gen_mode sysctl.
> > > 
> > > Signed-off-by: Guillaume Nault <gnault@...hat.com>
> > 
> > There are some helpers from lib.sh that could have been used,
> 
> Yes, I reused a personnal template that predates lib.sh. Given how
> simple is the setup of this selftest, I'm not sure if it's worth
> including lib.sh. But I might consider doing that in v2.

I've finally prefered to keep the script as-is. Reusing lib.sh wouldn't
simplify much, but would require to use bash. And just changing the
shebang to "#! /bin/bash" adds a 1.5 second penalty to the selftest
execution time. That's acceptable of course, but I'm getting a bit
tired of kselftests execution time, so I'd rather not contribute to
increasing it uselessly.

> > but the test is very clean and easy to follow, so:
> > 
> > Reviewed-by: Ido Schimmel <idosch@...dia.com>
> > Tested-by: Ido Schimmel <idosch@...dia.com>
> > 
> > Thanks!
> >