netdev - Re: [PATCH net v2 1/2] gre: Fix IPv6 link-local address generation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z73aWP2GTAfR9X2D@debian>
Date: Tue, 25 Feb 2025 15:57:28 +0100
From: Guillaume Nault <gnault@...hat.com>
To: Ido Schimmel <idosch@...sch.org>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	netdev@...r.kernel.org, Simon Horman <horms@...nel.org>,
	David Ahern <dsahern@...nel.org>,
	Antonio Quartulli <antonio@...delbit.com>
Subject: Re: [PATCH net v2 1/2] gre: Fix IPv6 link-local address generation.

On Mon, Feb 24, 2025 at 08:21:14PM +0200, Ido Schimmel wrote:
> On Mon, Feb 24, 2025 at 06:27:56PM +0100, Guillaume Nault wrote:
> > On Sun, Feb 23, 2025 at 03:16:08PM +0200, Ido Schimmel wrote:
> > > On Fri, Feb 21, 2025 at 10:24:04AM +0100, Guillaume Nault wrote:
> > > > Use addrconf_addr_gen() to generate IPv6 link-local addresses on GRE
> > > > devices in most cases and fall back to using add_v4_addrs() only in
> > > > case the GRE configuration is incompatible with addrconf_addr_gen().
> > > > 
> > > > GRE used to use addrconf_addr_gen() until commit e5dd729460ca
> > > > ("ip/ip6_gre: use the same logic as SIT interfaces when computing v6LL
> > > > address") restricted this use to gretap devices and created
> > > 
> > > It's not always clear throughout the commit message to which devices you
> > > are referring to.
> > 
> > Maybe the following terms would be clearer:
> > 'ip4gre', 'ip4gretap', 'ip6gre', 'ip6gretap' (and potentially 'ipXgre'
> > and 'ipXgretap' when considering both the IPv4 and IPv6 tunnel
> > versions). Would you find these terms clearer?
> 
> I'm fine with the above, but I also think that as long as "ip link"
> types (e.g., 'gre', 'ip6gre') are consistently used throughout the
> commit message, it should be clear which devices the commit message
> refers to. Whatever you prefer.

I've finally opted for reusing "ip link" types, plus a bit of rewording
to remove potential ambiguities.