netdev - RE: [PATCH v7 net-next 4/5] net: ena: PHC stats through sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c650369bb0394184951161eb34772a1a@amazon.com>
Date: Tue, 25 Feb 2025 17:53:25 +0000
From: "Arinzon, David" <darinzon@...zon.com>
To: Simon Horman <horms@...nel.org>
CC: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Eric Dumazet
	<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Richard Cochran
	<richardcochran@...il.com>, "Woodhouse, David" <dwmw@...zon.co.uk>,
	"Machulsky, Zorik" <zorik@...zon.com>, "Matushevsky, Alexander"
	<matua@...zon.com>, "Bshara, Saeed" <saeedb@...zon.com>, "Wilson, Matt"
	<msw@...zon.com>, "Liguori, Anthony" <aliguori@...zon.com>, "Bshara, Nafea"
	<nafea@...zon.com>, "Schmeilin, Evgeny" <evgenys@...zon.com>, "Belgazal,
 Netanel" <netanel@...zon.com>, "Saidi, Ali" <alisaidi@...zon.com>,
	"Herrenschmidt, Benjamin" <benh@...zon.com>, "Kiyanovski, Arthur"
	<akiyano@...zon.com>, "Dagan, Noam" <ndagan@...zon.com>, "Bernstein, Amit"
	<amitbern@...zon.com>, "Allen, Neil" <shayagr@...zon.com>, "Abboud, Osama"
	<osamaabb@...zon.com>, "Ostrovsky, Evgeny" <evostrov@...zon.com>, "Tabachnik,
 Ofir" <ofirt@...zon.com>, "Machnikowski, Maciek" <maciek@...hnikowski.net>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>, Gal Pressman <gal@...dia.com>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Subject: RE: [PATCH v7 net-next 4/5] net: ena: PHC stats through sysfs

> > The patch allows retrieving PHC statistics through sysfs.
> > In case the feature is not enabled (through `phc_enable` sysfs entry),
> > no output will be written.
> >
> > Signed-off-by: David Arinzon <darinzon@...zon.com>
> 
> ...
> 
> > diff --git a/drivers/net/ethernet/amazon/ena/ena_sysfs.c
> > b/drivers/net/ethernet/amazon/ena/ena_sysfs.c
> > index d0ded92d..10993594 100644
> > --- a/drivers/net/ethernet/amazon/ena/ena_sysfs.c
> > +++ b/drivers/net/ethernet/amazon/ena/ena_sysfs.c
> > @@ -65,6 +65,52 @@ static ssize_t ena_phc_enable_get(struct device
> > *dev,  static DEVICE_ATTR(phc_enable, S_IRUGO | S_IWUSR,
> ena_phc_enable_get,
> >                  ena_phc_enable_set);
> >
> > +#define ENA_STAT_ENA_COM_PHC_ENTRY(stat) { \
> > +     .name = #stat, \
> > +     .stat_offset = offsetof(struct ena_com_stats_phc, stat) /
> > +sizeof(u64) \ }
> > +
> > +const struct ena_stats ena_stats_ena_com_phc_strings[] = {
> > +     ENA_STAT_ENA_COM_PHC_ENTRY(phc_cnt),
> > +     ENA_STAT_ENA_COM_PHC_ENTRY(phc_exp),
> > +     ENA_STAT_ENA_COM_PHC_ENTRY(phc_skp),
> > +     ENA_STAT_ENA_COM_PHC_ENTRY(phc_err),
> > +};
> 
> Hi David,
> 
> Some very minor nits from my side:
> 
> Is seems that ena_stats_ena_com_phc_strings is only used in this file and
> thus should be static.
> 

Thanks Simon, I also saw it in the compilation warnings in patchwork.
This code will be modified/removed in v8.

Thanks,
David

> > +
> > +u16 ena_stats_array_ena_com_phc_size =
> > +ARRAY_SIZE(ena_stats_ena_com_phc_strings);
> 
> Likewise for ena_stats_array_ena_com_phc_size.
> 
> ...