netdev - Re: [PATCH v7 net-next 4/5] net: ena: PHC stats through sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250225093851.GJ1615191@kernel.org>
Date: Tue, 25 Feb 2025 09:38:51 +0000
From: Simon Horman <horms@...nel.org>
To: David Arinzon <darinzon@...zon.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
	Paolo Abeni <pabeni@...hat.com>,
	Richard Cochran <richardcochran@...il.com>,
	"Woodhouse, David" <dwmw@...zon.com>,
	"Machulsky, Zorik" <zorik@...zon.com>,
	"Matushevsky, Alexander" <matua@...zon.com>,
	Saeed Bshara <saeedb@...zon.com>, "Wilson, Matt" <msw@...zon.com>,
	"Liguori, Anthony" <aliguori@...zon.com>,
	"Bshara, Nafea" <nafea@...zon.com>,
	"Schmeilin, Evgeny" <evgenys@...zon.com>,
	"Belgazal, Netanel" <netanel@...zon.com>,
	"Saidi, Ali" <alisaidi@...zon.com>,
	"Herrenschmidt, Benjamin" <benh@...zon.com>,
	"Kiyanovski, Arthur" <akiyano@...zon.com>,
	"Dagan, Noam" <ndagan@...zon.com>,
	"Bernstein, Amit" <amitbern@...zon.com>,
	"Agroskin, Shay" <shayagr@...zon.com>,
	"Abboud, Osama" <osamaabb@...zon.com>,
	"Ostrovsky, Evgeny" <evostrov@...zon.com>,
	"Tabachnik, Ofir" <ofirt@...zon.com>,
	"Machnikowski, Maciek" <maciek@...hnikowski.net>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>,
	Gal Pressman <gal@...dia.com>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Subject: Re: [PATCH v7 net-next 4/5] net: ena: PHC stats through sysfs

On Tue, Feb 18, 2025 at 08:39:47PM +0200, David Arinzon wrote:
> The patch allows retrieving PHC statistics
> through sysfs.
> In case the feature is not enabled (through `phc_enable`
> sysfs entry), no output will be written.
> 
> Signed-off-by: David Arinzon <darinzon@...zon.com>

...

> diff --git a/drivers/net/ethernet/amazon/ena/ena_sysfs.c b/drivers/net/ethernet/amazon/ena/ena_sysfs.c
> index d0ded92d..10993594 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_sysfs.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_sysfs.c
> @@ -65,6 +65,52 @@ static ssize_t ena_phc_enable_get(struct device *dev,
>  static DEVICE_ATTR(phc_enable, S_IRUGO | S_IWUSR, ena_phc_enable_get,
>  		   ena_phc_enable_set);
>  
> +#define ENA_STAT_ENA_COM_PHC_ENTRY(stat) { \
> +	.name = #stat, \
> +	.stat_offset = offsetof(struct ena_com_stats_phc, stat) / sizeof(u64) \
> +}
> +
> +const struct ena_stats ena_stats_ena_com_phc_strings[] = {
> +	ENA_STAT_ENA_COM_PHC_ENTRY(phc_cnt),
> +	ENA_STAT_ENA_COM_PHC_ENTRY(phc_exp),
> +	ENA_STAT_ENA_COM_PHC_ENTRY(phc_skp),
> +	ENA_STAT_ENA_COM_PHC_ENTRY(phc_err),
> +};

Hi David,

Some very minor nits from my side:

Is seems that ena_stats_ena_com_phc_strings is only used in this file and
thus should be static.

> +
> +u16 ena_stats_array_ena_com_phc_size = ARRAY_SIZE(ena_stats_ena_com_phc_strings);

Likewise for ena_stats_array_ena_com_phc_size.

...