netdev - [PATCH net] netkit: Remove double invocation to clear ipvs property flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250225212927.69271-1-daniel@iogearbox.net>
Date: Tue, 25 Feb 2025 22:29:27 +0100
From: Daniel Borkmann <daniel@...earbox.net>
To: kuba@...nel.org
Cc: netdev@...r.kernel.org,
	bpf@...r.kernel.org,
	Philo Lu <lulie@...ux.alibaba.com>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Martin KaFai Lau <martin.lau@...nel.org>
Subject: [PATCH net] netkit: Remove double invocation to clear ipvs property flag

With ipvs_reset() now done unconditionally in skb_scrub_packet()
we would then call the former twice netkit_prep_forward(). Thus
remove the now unnecessary explicit call.

Fixes: de2c211868b9 ("ipvs: Always clear ipvs_property flag in skb_scrub_packet()")
Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
Cc: Philo Lu <lulie@...ux.alibaba.com>
Cc: Nikolay Aleksandrov <razor@...ckwall.org>
Cc: Martin KaFai Lau <martin.lau@...nel.org>
---
 [ Sending to net since de2c211868b9 is in net ]

 drivers/net/netkit.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/netkit.c b/drivers/net/netkit.c
index 1e1b00756be7..20088f781376 100644
--- a/drivers/net/netkit.c
+++ b/drivers/net/netkit.c
@@ -65,7 +65,6 @@ static void netkit_prep_forward(struct sk_buff *skb,
 	skb_reset_mac_header(skb);
 	if (!xnet)
 		return;
-	ipvs_reset(skb);
 	skb_clear_tstamp(skb);
 	if (xnet_scrub)
 		netkit_xnet(skb);
-- 
2.43.0