netdev - Re: [PATCH net] netkit: Remove double invocation to clear ipvs property flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df2b1a91-89a4-40e8-b0d6-b666b17efb5a@blackwall.org>
Date: Wed, 26 Feb 2025 11:48:52 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Daniel Borkmann <daniel@...earbox.net>, kuba@...nel.org
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org,
 Philo Lu <lulie@...ux.alibaba.com>, Martin KaFai Lau <martin.lau@...nel.org>
Subject: Re: [PATCH net] netkit: Remove double invocation to clear ipvs
 property flag

On 2/25/25 23:29, Daniel Borkmann wrote:
> With ipvs_reset() now done unconditionally in skb_scrub_packet()
> we would then call the former twice netkit_prep_forward(). Thus
> remove the now unnecessary explicit call.
> 
> Fixes: de2c211868b9 ("ipvs: Always clear ipvs_property flag in skb_scrub_packet()")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Cc: Philo Lu <lulie@...ux.alibaba.com>
> Cc: Nikolay Aleksandrov <razor@...ckwall.org>
> Cc: Martin KaFai Lau <martin.lau@...nel.org>
> ---
>  [ Sending to net since de2c211868b9 is in net ]
> 
>  drivers/net/netkit.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/netkit.c b/drivers/net/netkit.c
> index 1e1b00756be7..20088f781376 100644
> --- a/drivers/net/netkit.c
> +++ b/drivers/net/netkit.c
> @@ -65,7 +65,6 @@ static void netkit_prep_forward(struct sk_buff *skb,
>  	skb_reset_mac_header(skb);
>  	if (!xnet)
>  		return;
> -	ipvs_reset(skb);
>  	skb_clear_tstamp(skb);
>  	if (xnet_scrub)
>  		netkit_xnet(skb);

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>