netdev - Re: [PATCH net] netkit: Remove double invocation to clear ipvs property flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250226173345.61fbff5c@kernel.org>
Date: Wed, 26 Feb 2025 17:33:45 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Daniel Borkmann <daniel@...earbox.net>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, Philo Lu
 <lulie@...ux.alibaba.com>, Nikolay Aleksandrov <razor@...ckwall.org>,
 Martin KaFai Lau <martin.lau@...nel.org>
Subject: Re: [PATCH net] netkit: Remove double invocation to clear ipvs
 property flag

On Tue, 25 Feb 2025 22:29:27 +0100 Daniel Borkmann wrote:
> With ipvs_reset() now done unconditionally in skb_scrub_packet()
> we would then call the former twice netkit_prep_forward(). Thus
> remove the now unnecessary explicit call.
> 
> Fixes: de2c211868b9 ("ipvs: Always clear ipvs_property flag in skb_scrub_packet()")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Cc: Philo Lu <lulie@...ux.alibaba.com>
> Cc: Nikolay Aleksandrov <razor@...ckwall.org>
> Cc: Martin KaFai Lau <martin.lau@...nel.org>
> ---
>  [ Sending to net since de2c211868b9 is in net ]

I see. But if that's okay with you we'll apply it to net-next tomorrow,
once the trees converge?