netdev - Re: [PATCH v1 net] net: Use rtnl_net_dev_lock() in register_netdevice_notifier_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLKeu=fQAyo=jPudR5MQ0ay901xhG+rG=4MWw0fpcDN=Q@mail.gmail.com>
Date: Wed, 26 Feb 2025 11:37:08 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org, 
	Breno Leitao <leitao@...ian.org>
Subject: Re: [PATCH v1 net] net: Use rtnl_net_dev_lock() in register_netdevice_notifier_dev_net().

On Tue, Feb 25, 2025 at 10:10 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> Breno Leitao reported the splat below. [0]
>
> Commit 65161fb544aa ("net: Fix dev_net(dev) race in
> unregister_netdevice_notifier_dev_net().") added the
> DEBUG_NET_WARN_ON_ONCE(), assuming that the netdev is not
> registered before register_netdevice_notifier_dev_net().
>
> But the assumption was simply wrong.
>
> Let's use rtnl_net_dev_lock() in register_netdevice_notifier_dev_net().
>
> [0]:
> WARNING: CPU: 25 PID: 849 at net/core/dev.c:2150 register_netdevice_notifier_dev_net (net/core/dev.c:2150)
>  <TASK>
>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>