netdev - Re: [PATCH v1 net] net: Use rtnl_net_dev_lock() in register_netdevice_notifier_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250226-resolute-azure-crocodile-ff7102@leitao>
Date: Wed, 26 Feb 2025 02:53:03 -0800
From: Breno Leitao <leitao@...ian.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net] net: Use rtnl_net_dev_lock() in
 register_netdevice_notifier_dev_net().

On Tue, Feb 25, 2025 at 01:10:23PM -0800, Kuniyuki Iwashima wrote:
> Breno Leitao reported the splat below. [0]
> 
> Commit 65161fb544aa ("net: Fix dev_net(dev) race in
> unregister_netdevice_notifier_dev_net().") added the
> DEBUG_NET_WARN_ON_ONCE(), assuming that the netdev is not
> registered before register_netdevice_notifier_dev_net().
> 
> But the assumption was simply wrong.
> 
> Let's use rtnl_net_dev_lock() in register_netdevice_notifier_dev_net().
> 
> [0]:
> WARNING: CPU: 25 PID: 849 at net/core/dev.c:2150 register_netdevice_notifier_dev_net (net/core/dev.c:2150)
>  <TASK>
>  ? __warn (kernel/panic.c:242 kernel/panic.c:748)
>  ? register_netdevice_notifier_dev_net (net/core/dev.c:2150)
>  ? register_netdevice_notifier_dev_net (net/core/dev.c:2150)
>  ? report_bug (lib/bug.c:? lib/bug.c:219)
>  ? handle_bug (arch/x86/kernel/traps.c:285)
>  ? exc_invalid_op (arch/x86/kernel/traps.c:309)
>  ? asm_exc_invalid_op (./arch/x86/include/asm/idtentry.h:621)
>  ? register_netdevice_notifier_dev_net (net/core/dev.c:2150)
>  ? register_netdevice_notifier_dev_net (./include/net/net_namespace.h:406 ./include/linux/netdevice.h:2663 net/core/dev.c:2144)
>  mlx5e_mdev_notifier_event+0x9f/0xf0 mlx5_ib
>  notifier_call_chain.llvm.12241336988804114627 (kernel/notifier.c:85)
>  blocking_notifier_call_chain (kernel/notifier.c:380)
>  mlx5_core_uplink_netdev_event_replay (drivers/net/ethernet/mellanox/mlx5/core/main.c:352)
>  mlx5_ib_roce_init.llvm.12447516292400117075+0x1c6/0x550 mlx5_ib
>  mlx5r_probe+0x375/0x6a0 mlx5_ib
>  ? kernfs_put (./include/linux/instrumented.h:96 ./include/linux/atomic/atomic-arch-fallback.h:2278 ./include/linux/atomic/atomic-instrumented.h:1384 fs/kernfs/dir.c:557)
>  ? auxiliary_match_id (drivers/base/auxiliary.c:174)
>  ? mlx5r_mp_remove+0x160/0x160 mlx5_ib
>  really_probe (drivers/base/dd.c:? drivers/base/dd.c:658)
>  driver_probe_device (drivers/base/dd.c:830)
>  __driver_attach (drivers/base/dd.c:1217)
>  bus_for_each_dev (drivers/base/bus.c:369)
>  ? driver_attach (drivers/base/dd.c:1157)
>  bus_add_driver (drivers/base/bus.c:679)
>  driver_register (drivers/base/driver.c:249)
> 
> Fixes: 7fb1073300a2 ("net: Hold rtnl_net_lock() in (un)?register_netdevice_notifier_dev_net().")
> Reported-by: Breno Leitao <leitao@...ian.org>
> Closes: https://lore.kernel.org/netdev/20250224-noisy-cordial-roadrunner-fad40c@leitao/
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Tested-by: Breno Leitao <leitao@...ian.org>