netdev - Re: [PATCH v1 net-next 02/12] ipv4: fib: Allocate fib_info_hash[] and fib_info_laddrhash[] by kvmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKEQ2CqSdi4U5_91MU0pCsa+604U7pDFuZXEM7Rjw70zg@mail.gmail.com>
Date: Wed, 26 Feb 2025 12:08:03 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 02/12] ipv4: fib: Allocate fib_info_hash[] and
 fib_info_laddrhash[] by kvmalloc_array().

On Tue, Feb 25, 2025 at 7:24 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> Both fib_info_hash[] and fib_info_laddrhash[] are hash tables for
> struct fib_info and are allocated by kvzmalloc() separately.
>
> Let's replace the two kvzmalloc() calls with kvmalloc_array() to
> remove the fib_info_laddrhash pointer later.
>
> Note that fib_info_hash_alloc() allocates a new hash table based on
> fib_info_hash_bits because we will remove fib_info_hash_size later.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>