netdev - [PATCH iproute2-net] ss: mptcp: subflow: display seq counters as decimal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250226-iproute2-net-ss-ulp-mptcp-dec-v1-1-4f4177cff217@kernel.org>
Date: Wed, 26 Feb 2025 12:08:44 +0100
From: "Matthieu Baerts (NGI0)" <matttbe@...nel.org>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: David Ahern <dsahern@...il.com>, netdev@...r.kernel.org, 
 MPTCP Upstream <mptcp@...ts.linux.dev>, 
 Mat Martineau <martineau@...nel.org>, Geliang Tang <geliang@...nel.org>, 
 Davide Caratti <dcaratti@...hat.com>, 
 "Matthieu Baerts (NGI0)" <matttbe@...nel.org>
Subject: [PATCH iproute2-net] ss: mptcp: subflow: display seq counters as
 decimal

This is similar to commit cfa70237 ("ss: mptcp: display seq related
counters as decimal") but for the subflow info this time. This is also
aligned with what is printed for TCP sockets.

That looks better to do the same with the subflow info (ss -ti), to
compare with the MPTCP info (ss -Mi), or for those who want to easily
count how many bytes have been exchanged between two runs without having
to think in hexa.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
---
 misc/ss.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/misc/ss.c b/misc/ss.c
index aef1a714b130900d6f3061c150639235c1eb13ca..6d5976501467842b1681d7dfc1ca56cc1b4a98d5 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -3055,16 +3055,16 @@ static void mptcp_subflow_info(struct rtattr *tb[])
 		    rta_getattr_u32(tb[MPTCP_SUBFLOW_ATTR_TOKEN_LOC]),
 		    rta_getattr_u8(tb[MPTCP_SUBFLOW_ATTR_ID_LOC]));
 	if (tb[MPTCP_SUBFLOW_ATTR_MAP_SEQ])
-		out(" seq:%llx",
+		out(" seq:%llu",
 		    rta_getattr_u64(tb[MPTCP_SUBFLOW_ATTR_MAP_SEQ]));
 	if (tb[MPTCP_SUBFLOW_ATTR_MAP_SFSEQ])
-		out(" sfseq:%x",
+		out(" sfseq:%u",
 		    rta_getattr_u32(tb[MPTCP_SUBFLOW_ATTR_MAP_SFSEQ]));
 	if (tb[MPTCP_SUBFLOW_ATTR_SSN_OFFSET])
-		out(" ssnoff:%x",
+		out(" ssnoff:%u",
 		    rta_getattr_u32(tb[MPTCP_SUBFLOW_ATTR_SSN_OFFSET]));
 	if (tb[MPTCP_SUBFLOW_ATTR_MAP_DATALEN])
-		out(" maplen:%x",
+		out(" maplen:%u",
 		    rta_getattr_u32(tb[MPTCP_SUBFLOW_ATTR_MAP_DATALEN]));
 }
 

---
base-commit: 48717184ba3700938b75542046c5108b21e95ea7
change-id: 20250226-iproute2-net-ss-ulp-mptcp-dec-92801e84ac6f

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@...nel.org>