netdev - Re: [PATCH v1 net-next 04/12] ipv4: fib: Make fib_info_hashfn() return struct hlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJXmQaZ7Ar+HGx1eZuH9TQwZ_BhVYEhgwE6re7uU8Dteg@mail.gmail.com>
Date: Wed, 26 Feb 2025 12:13:25 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 04/12] ipv4: fib: Make fib_info_hashfn()
 return struct hlist_head.

On Tue, Feb 25, 2025 at 7:24 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> Every time fib_info_hashfn() returns a hash value, we fetch
> &fib_info_hash[hash].
>
> Let's return the hlist_head pointer from fib_info_hashfn() and
> rename it to fib_info_hash_bucket() to match a similar function,
> fib_info_laddrhash_bucket().
>
> Note that we need to move the fib_info_hash assignment earlier in
> fib_info_hash_move() to use fib_info_hash_bucket() in the for loop.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Nice !

Reviewed-by: Eric Dumazet <edumazet@...gle.com>