netdev - Re: [PATCH v1 net-next 05/12] ipv4: fib: Remove fib_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+i+RVHoOa8C_-6GX94Jwmth1jceVDh_uHgKVRJBCTPWA@mail.gmail.com>
Date: Wed, 26 Feb 2025 12:15:13 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 05/12] ipv4: fib: Remove fib_info_laddrhash pointer.

On Tue, Feb 25, 2025 at 7:25 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> We will allocate the fib_info hash tables per netns.
>
> There are 5 global variables for fib_info hash tables:
> fib_info_hash, fib_info_laddrhash, fib_info_hash_size,
> fib_info_hash_bits, fib_info_cnt.
>
> However, fib_info_laddrhash and fib_info_hash_size can be
> easily calculated from fib_info_hash and fib_info_hash_bits.
>
> Let's remove the fib_info_laddrhash pointer and instead use
> fib_info_hash + (1 << fib_info_hash_bits).
>
> While at it, fib_info_laddrhash_bucket() is moved near other
> hash-table-specific functions.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>