netdev - Re: [PATCH net-next 5/5] ice: dpll: Remove newline at the end of a netlink error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20879a01-348e-4bec-a880-41e8a6904e60@intel.com>
Date: Wed, 26 Feb 2025 14:48:53 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Gal Pressman <gal@...dia.com>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	<netdev@...r.kernel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>, "Tariq
 Toukan" <tariqt@...dia.com>, Edward Cree <ecree.xilinx@...il.com>, "Martin
 Habets" <habetsm.xilinx@...il.com>, Jamal Hadi Salim <jhs@...atatu.com>,
	"Cong Wang" <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, Simon
 Horman <horms@...nel.org>, Julia Lawall <Julia.Lawall@...ia.fr>, Nicolas
 Palix <nicolas.palix@...g.fr>, Tony Nguyen <anthony.l.nguyen@...el.com>,
	"Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
Subject: Re: [PATCH net-next 5/5] ice: dpll: Remove newline at the end of a
 netlink error message

On 2/26/25 10:39, Gal Pressman wrote:
> Netlink error messages should not have a newline at the end of the
> string.
> 
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> Signed-off-by: Gal Pressman <gal@...dia.com>

Acked-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

> ---
>   drivers/net/ethernet/intel/ice/ice_dpll.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethernet/intel/ice/ice_dpll.c
> index 8d806d8ad761..bce3ad6ca2a6 100644
> --- a/drivers/net/ethernet/intel/ice/ice_dpll.c
> +++ b/drivers/net/ethernet/intel/ice/ice_dpll.c
> @@ -95,7 +95,7 @@ ice_dpll_pin_freq_set(struct ice_pf *pf, struct ice_dpll_pin *pin,
>   	}
>   	if (ret) {
>   		NL_SET_ERR_MSG_FMT(extack,
> -				   "err:%d %s failed to set pin freq:%u on pin:%u\n",
> +				   "err:%d %s failed to set pin freq:%u on pin:%u",
[...]