netdev - Re: [PATCH net-next 0/5] Add missing netlink error message macros to coccinelle test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7/7E0kfDHvK1hXd@mev-dev.igk.intel.com>
Date: Thu, 27 Feb 2025 06:41:39 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Gal Pressman <gal@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
	Tony Nguyen <anthony.l.nguyen@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Tariq Toukan <tariqt@...dia.com>,
	Edward Cree <ecree.xilinx@...il.com>,
	Martin Habets <habetsm.xilinx@...il.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
	Simon Horman <horms@...nel.org>,
	Julia Lawall <Julia.Lawall@...ia.fr>,
	Nicolas Palix <nicolas.palix@...g.fr>
Subject: Re: [PATCH net-next 0/5] Add missing netlink error message macros to
 coccinelle test

On Wed, Feb 26, 2025 at 11:38:59AM +0200, Gal Pressman wrote:
> The newline_in_nl_msg.cocci test is missing some variants in the list of
> checked macros, add them and fix all reported issues.
> 
> Thanks,
> Gal
> 
> Gal Pressman (5):
>   coccinelle: Add missing (GE)NL_SET_ERR_MSG_* to strings ending with
>     newline test
>   net/mlx5: Remove newline at the end of a netlink error message
>   sfc: Remove newline at the end of a netlink error message
>   net: sched: Remove newline at the end of a netlink error message
>   ice: dpll: Remove newline at the end of a netlink error message
> 
>  drivers/net/ethernet/intel/ice/ice_dpll.c          | 14 +++++++-------
>  drivers/net/ethernet/mellanox/mlx5/core/dpll.c     |  2 +-
>  .../ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c  |  2 +-
>  .../net/ethernet/mellanox/mlx5/core/en_ethtool.c   |  2 +-
>  .../net/ethernet/mellanox/mlx5/core/esw/bridge.c   |  6 +++---
>  drivers/net/ethernet/sfc/mae.c                     |  2 +-
>  drivers/net/ethernet/sfc/tc.c                      |  6 +++---
>  net/sched/sch_qfq.c                                |  2 +-
>  scripts/coccinelle/misc/newline_in_nl_msg.cocci    | 13 ++++++++-----
>  9 files changed, 26 insertions(+), 23 deletions(-)
> 

I looked at the whole series, thanks:
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

> -- 
> 2.40.1