netdev - Re: [PATCH net-next v7 4/8] net: pktgen: fix mpls maximum labels list parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250227144243.6953f14e@gmx.net>
Date: Thu, 27 Feb 2025 14:42:43 +0100
From: Peter Seiderer <ps.report@....net>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Simon
 Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>, Thomas Gleixner
 <tglx@...utronix.de>, Artem Chernyshev <artem.chernyshev@...-soft.ru>,
 Frederic Weisbecker <frederic@...nel.org>, Nam Cao <namcao@...utronix.de>
Subject: Re: [PATCH net-next v7 4/8] net: pktgen: fix mpls maximum labels
 list parsing

Hello Paolo,

On Thu, 27 Feb 2025 11:24:48 +0100, Paolo Abeni <pabeni@...hat.com> wrote:

> On 2/24/25 10:22 AM, Peter Seiderer wrote:
> > Fix mpls maximum labels list parsing up to MAX_MPLS_LABELS/16 entries
> > (instead of up to MAX_MPLS_LABELS - 1).
>
> Very minor nit...
>
> The above comments sounds misleading to me. I read it as the new limit
> is MAX_MPLS_LABELS divided by 16, that is 1.

O.k, will rephrase on next patch iteration, thanks for review!

Regards,
Peter

>
> Thanks,
>
> Paolo
>