| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250227083445.7613e2b9@kernel.org>
Date: Thu, 27 Feb 2025 08:34:45 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Alvin Šipraga <alsi@...g-olufsen.dk>, Andrew Lunn
<andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
<pabeni@...hat.com>, Luiz Angelo Daros de Luca <luizluca@...il.com>,
netdev@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v3] net: dsa: rtl8366rb: Fix compilation problem
On Thu, 20 Feb 2025 19:48:15 +0100 Linus Walleij wrote:
> +config NET_DSA_REALTEK_RTL8366RB_LEDS
> + bool "Support RTL8366RB LED control"
> + depends on (LEDS_CLASS=y || LEDS_CLASS=NET_DSA_REALTEK_RTL8366RB)
> + depends on NET_DSA_REALTEK_RTL8366RB
> + default NET_DSA_REALTEK_RTL8366RB
Is there a reason to prompt the user for this choice?
IOW is it okay if I do:
diff --git a/drivers/net/dsa/realtek/Kconfig b/drivers/net/dsa/realtek/Kconfig
index 10687722d14c..d6eb6713e5f6 100644
--- a/drivers/net/dsa/realtek/Kconfig
+++ b/drivers/net/dsa/realtek/Kconfig
@@ -44,7 +44,7 @@ config NET_DSA_REALTEK_RTL8366RB
Select to enable support for Realtek RTL8366RB.
config NET_DSA_REALTEK_RTL8366RB_LEDS
- bool "Support RTL8366RB LED control"
+ bool
depends on (LEDS_CLASS=y || LEDS_CLASS=NET_DSA_REALTEK_RTL8366RB)
depends on NET_DSA_REALTEK_RTL8366RB
default NET_DSA_REALTEK_RTL8366RB
?
Powered by blists - more mailing lists