netdev - Re: [PATCH v3] net: dsa: rtl8366rb: Fix compilation problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdahvGRx-ZS-dqYouiBzaCR2bNvc_tPOtz_cepRc4Opuyw@mail.gmail.com>
Date: Thu, 27 Feb 2025 23:50:02 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Alvin Šipraga <alsi@...g-olufsen.dk>, 
	Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Luiz Angelo Daros de Luca <luizluca@...il.com>, netdev@...r.kernel.org, 
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v3] net: dsa: rtl8366rb: Fix compilation problem

On Thu, Feb 27, 2025 at 5:34 PM Jakub Kicinski <kuba@...nel.org> wrote:
> On Thu, 20 Feb 2025 19:48:15 +0100 Linus Walleij wrote:
> > +config NET_DSA_REALTEK_RTL8366RB_LEDS
> > +     bool "Support RTL8366RB LED control"
> > +     depends on (LEDS_CLASS=y || LEDS_CLASS=NET_DSA_REALTEK_RTL8366RB)
> > +     depends on NET_DSA_REALTEK_RTL8366RB
> > +     default NET_DSA_REALTEK_RTL8366RB
>
> Is there a reason to prompt the user for this choice?
> IOW is it okay if I do:

Yeah that's OK, go ahead.

Yours,
Linus Walleij