netdev - [PATCH iproute] libgenl: report a verbose error if rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250228133431.20296-1-kirjanov@gmail.com>
Date: Fri, 28 Feb 2025 16:34:31 +0300
From: Denis Kirjanov <kirjanov@...il.com>
To: stephen@...workplumber.org,
	dsahern@...nel.org
Cc: netdev@...r.kernel.org,
	Denis Kirjanov <kirjanov@...il.com>
Subject: [PATCH iproute] libgenl: report a verbose error if rtnl_talk fails

Currenlty rtnl_talk() doesn't give us the reason
if it fails.

Signed-off-by: Denis Kirjanov <kirjanov@...il.com>
---
 lib/libgenl.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/libgenl.c b/lib/libgenl.c
index fca07f9f..9927af84 100644
--- a/lib/libgenl.c
+++ b/lib/libgenl.c
@@ -58,7 +58,8 @@ int genl_resolve_family(struct rtnl_handle *grth, const char *family)
 		  family, strlen(family) + 1);
 
 	if (rtnl_talk(grth, &req.n, &answer) < 0) {
-		fprintf(stderr, "Error talking to the kernel\n");
+		fprintf(stderr, "Error talking to the kernel: %s (errno %d)\n",
+			strerror(errno), errno);
 		return -2;
 	}
 
@@ -103,7 +104,8 @@ int genl_add_mcast_grp(struct rtnl_handle *grth, __u16 fnum, const char *group)
 	addattr16(&req.n, sizeof(req), CTRL_ATTR_FAMILY_ID, fnum);
 
 	if (rtnl_talk(grth, &req.n, &answer) < 0) {
-		fprintf(stderr, "Error talking to the kernel\n");
+		fprintf(stderr, "Error talking to the kernel: %s (errno %d)\n",
+			strerror(errno), errno);
 		return -2;
 	}
 
-- 
2.43.0