netdev - Re: [PATCH iproute] libgenl: report a verbose error if rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250310091212.7dba57d2@hermes.local>
Date: Mon, 10 Mar 2025 09:12:12 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Denis Kirjanov <kirjanov@...il.com>
Cc: dsahern@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH iproute] libgenl: report a verbose error if rtnl_talk
 fails

On Fri, 28 Feb 2025 16:34:31 +0300
Denis Kirjanov <kirjanov@...il.com> wrote:

> Currenlty rtnl_talk() doesn't give us the reason
> if it fails.
> 
> Signed-off-by: Denis Kirjanov <kirjanov@...il.com>
> ---

Don't think this is needed.
 - inside rtnl_talk, it already prints (using perror) if it is a kernel reported error
 - lots of other places call rtnl_talk() what is special about genl

Better to move any required error prints into libnetlink.c

Even better is to make sure any errors in kernel are using extack to give
better messages.