netdev - Re: [PATCH net-next 1/2] ipv4: icmp: do not process ICMP_EXT_ECHOREPLY for broadcast/multicast addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7801d1bc-ff7d-4a83-9e56-4890132ba738@kernel.org>
Date: Fri, 28 Feb 2025 09:28:11 -0700
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
 eric.dumazet@...il.com
Subject: Re: [PATCH net-next 1/2] ipv4: icmp: do not process
 ICMP_EXT_ECHOREPLY for broadcast/multicast addresses

On 2/26/25 11:34 AM, Eric Dumazet wrote:
> There is no point processing ICMP_EXT_ECHOREPLY for routes
> which would drop ICMP_ECHOREPLY (RFC 1122 3.2.2.6, 3.2.2.8)
> 
> This seems an oversight of the initial implementation.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  net/ipv4/icmp.c | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
>

Reviewed-by: David Ahern <dsahern@...nel.org>