netdev - Re: [PATCH net-next 2/2] inet: ping: avoid skb_clone() dance in ping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02e5bf07-b722-475e-91e5-78def5e6a83a@kernel.org>
Date: Fri, 28 Feb 2025 09:30:32 -0700
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
 eric.dumazet@...il.com
Subject: Re: [PATCH net-next 2/2] inet: ping: avoid skb_clone() dance in
 ping_rcv()

On 2/26/25 11:34 AM, Eric Dumazet wrote:
> ping_rcv() callers currently call skb_free() or consume_skb(),
> forcing ping_rcv() to clone the skb.
> 
> After this patch ping_rcv() is now 'consuming' the original skb,
> either moving to a socket receive queue, or dropping it.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  net/ipv4/icmp.c |  5 +++--
>  net/ipv4/ping.c | 20 +++++---------------
>  net/ipv6/icmp.c |  7 ++-----
>  3 files changed, 10 insertions(+), 22 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>