netdev - Re: [PATCH v3 03/19] crypto: scatterwalk - add new functions for iterating through data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8P6qOt4DQ3_FkMo@gondor.apana.org.au>
Date: Sun, 2 Mar 2025 14:28:56 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH v3 03/19] crypto: scatterwalk - add new functions for
 iterating through data

Eric Biggers <ebiggers@...nel.org> wrote:
>
> +static inline void scatterwalk_done_src(struct scatter_walk *walk,
> +                                       const void *vaddr, unsigned int nbytes)
> +{
> +       scatterwalk_unmap((void *)vaddr);

Please send an incremental patch to eliminate this cast by making
scatterwalk_unmap take a const void * just like kunmap_local.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt