netdev - Re: [PATCH v3 04/19] crypto: scatterwalk - add new functions for copying data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8P9eIGDlT3fs1gS@gondor.apana.org.au>
Date: Sun, 2 Mar 2025 14:40:56 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, David Howells <dhowells@...hat.com>,
	Akinobu Mita <akinobu.mita@...il.com>, Tejun Heo <htejun@...il.com>
Subject: Re: [PATCH v3 04/19] crypto: scatterwalk - add new functions for
 copying data

Eric Biggers <ebiggers@...nel.org> wrote:
>
> +void memcpy_from_sglist(void *buf, struct scatterlist *sg,
> +                       unsigned int start, unsigned int nbytes)
> {
>        struct scatter_walk walk;
> -       struct scatterlist tmp[2];
> 
> -       if (!nbytes)
> +       if (unlikely(nbytes == 0)) /* in case sg == NULL */
>                return;
> 
> -       sg = scatterwalk_ffwd(tmp, sg, start);
> +       scatterwalk_start_at_pos(&walk, sg, start);
> +       memcpy_from_scatterwalk(buf, &walk, nbytes);
> +}
> +EXPORT_SYMBOL_GPL(memcpy_from_sglist);
> +
> +void memcpy_to_sglist(struct scatterlist *sg, unsigned int start,
> +                     const void *buf, unsigned int nbytes)

These functions duplicate sg_copy_buffer.  Of course scatterwalk
in general duplicates SG miter which came later IIRC.

What's your plan for eliminating this duplication?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt