netdev - Re: [PATCH net-next v2 9/9] eth: bnxt: count xdp xmit packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLim64PEa=y2dchoq0QR_+sm7Bigr6H0CXB4UFQg8s0gnQQ@mail.gmail.com>
Date: Tue, 4 Mar 2025 14:48:05 -0800
From: Michael Chan <michael.chan@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, 
	pavan.chebbi@...adcom.com, przemyslaw.kitszel@...el.com
Subject: Re: [PATCH net-next v2 9/9] eth: bnxt: count xdp xmit packets

On Thu, Feb 27, 2025 at 5:25 PM Jakub Kicinski <kuba@...nel.org> wrote:

> @@ -1134,6 +1137,8 @@ struct bnxt_tx_sw_stats {
>         /* non-ethtool stats follow */
>         u64                     tx_packets;
>         u64                     tx_bytes;
> +       u64                     xdp_packets; /* under rx syncp */
> +       u64                     xdp_bytes;  /* under rx syncp */

Why do we need different TX counters for XDP?  A TX ring is either for
XDP or for regular TX.  It cannot be for both so why do we need
separate counters?

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4196 bytes)