netdev - Re: [PATCH v8 net-next 4/5] net: ena: PHC stats through sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250304145857.61a3bd6e@kernel.org>
Date: Tue, 4 Mar 2025 14:58:57 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: David Arinzon <darinzon@...zon.com>, David Miller <davem@...emloft.net>,
 netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Richard Cochran
 <richardcochran@...il.com>, "Woodhouse, David" <dwmw@...zon.com>,
 "Machulsky, Zorik" <zorik@...zon.com>, "Matushevsky, Alexander"
 <matua@...zon.com>, Saeed Bshara <saeedb@...zon.com>, "Wilson, Matt"
 <msw@...zon.com>, "Liguori, Anthony" <aliguori@...zon.com>, "Bshara, Nafea"
 <nafea@...zon.com>, "Schmeilin, Evgeny" <evgenys@...zon.com>, "Belgazal,
 Netanel" <netanel@...zon.com>, "Saidi, Ali" <alisaidi@...zon.com>,
 "Herrenschmidt, Benjamin" <benh@...zon.com>, "Kiyanovski, Arthur"
 <akiyano@...zon.com>, "Dagan, Noam" <ndagan@...zon.com>, "Bernstein, Amit"
 <amitbern@...zon.com>, "Agroskin, Shay" <shayagr@...zon.com>, "Ostrovsky,
 Evgeny" <evostrov@...zon.com>, "Tabachnik, Ofir" <ofirt@...zon.com>,
 "Machnikowski, Maciek" <maciek@...hnikowski.net>, Rahul Rameshbabu
 <rrameshbabu@...dia.com>, Gal Pressman <gal@...dia.com>, Vadim Fedorenko
 <vadim.fedorenko@...ux.dev>
Subject: Re: [PATCH v8 net-next 4/5] net: ena: PHC stats through sysfs

On Tue, 4 Mar 2025 22:07:39 +0100 Andrew Lunn wrote:
> I've not been following previous versions of this patch, so i could be
> repeating questions already asked....
> 
> ena_adapter represents a netdev?
> 
> /* adapter specific private data structure */
> struct ena_adapter {
> 	struct ena_com_dev *ena_dev;
> 	/* OS defined structs */
> 	struct net_device *netdev;
> 
> So why are you not using the usual statistics interface for a netdev?

I asked them to do this.
They are using a PTP device as a pure clock. The netdev doesn't support
any HW timestamping, so none of the stats are related to packets. 
The PTP clock could as well be attached to a storage PCIe device. 
In that way it's more like the OCP PTP driver or other pure clocks 
in my eyes. And such drivers use sysfs, given they have no netdev.