netdev - Re: [PATCH net-next] net/mlnx5: Use generic code for page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250305185222.ryCIhbOs@linutronix.de>
Date: Wed, 5 Mar 2025 19:52:22 +0100
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Andrew Lunn <andrew@...n.ch>
Cc: linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Joe Damato <jdamato@...tly.com>,
	Leon Romanovsky <leon@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Saeed Mahameed <saeedm@...dia.com>,
	Tariq Toukan <tariqt@...dia.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH net-next] net/mlnx5: Use generic code for page_pool
 statistics.

On 2025-03-05 18:43:39 [+0100], Andrew Lunn wrote:
> > diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h
> > index f45d55e6e8643..78984b9286c6b 100644
> > --- a/include/net/page_pool/types.h
> > +++ b/include/net/page_pool/types.h
> > @@ -143,10 +143,14 @@ struct page_pool_recycle_stats {
> >   */
> >  struct page_pool_stats {
> >  	struct page_pool_alloc_stats alloc_stats;
> >  	struct page_pool_recycle_stats recycle_stats;
> >  };
> > +
> > +#else /* !CONFIG_PAGE_POOL_STATS */
> > +
> > +struct page_pool_stats { };
> >  #endif
>   
> Please do add this, in a separate patch. But i wounder how other
> drivers handle this. Do they also have #ifdef?

veth.c, fec_main.c, yes.
mvneta.c, mtk_eth_soc.c, no. But then they select PAGE_POOL_STATS so it
is not exactly a fair comparison.

>     Andrew

Sebastian