netdev - Re: [PATCH net] net/mlx5: Fill out devlink dev info only for PFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53c284be-f435-4945-a8eb-58278bf499ad@gmail.com>
Date: Wed, 5 Mar 2025 20:55:15 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, saeedm@...dia.com, leon@...nel.org, tariqt@...dia.com,
 andrew+netdev@...n.ch
Subject: Re: [PATCH net] net/mlx5: Fill out devlink dev info only for PFs



On 03/03/2025 15:32, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> Firmware version query is supported on the PFs. Due to this
> following kernel warning log is observed:
> 
> [  188.590344] mlx5_core 0000:08:00.2: mlx5_fw_version_query:816:(pid 1453): fw query isn't supported by the FW
> 
> Fix it by restricting the query and devlink info to the PF.
> 
> Fixes: 8338d9378895 ("net/mlx5: Added devlink info callback")
> Signed-off-by: Jiri Pirko <jiri@...dia.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> index 98d4306929f3..a2cf3e79693d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> @@ -46,6 +46,9 @@ mlx5_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req,
>   	u32 running_fw, stored_fw;
>   	int err;
>   
> +	if (!mlx5_core_is_pf(dev))
> +		return 0;
> +
>   	err = devlink_info_version_fixed_put(req, "fw.psid", dev->board_id);
>   	if (err)
>   		return err;

Reviewed-by: Tariq Toukan <tariqt@...dia.com>

Thanks.