netdev - Re: [PATCH net-next 3/3] eth: fbnic: support ring size configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8nj1Aq7TC3V6WOc@LQ3V64L9R2>
Date: Thu, 6 Mar 2025 10:05:08 -0800
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	alexanderduyck@...com
Subject: Re: [PATCH net-next 3/3] eth: fbnic: support ring size configuration

On Thu, Mar 06, 2025 at 06:51:50AM -0800, Jakub Kicinski wrote:
> Support ethtool -g / -G. Leverage the code added for -l / -L
> to alloc / stop / start / free.
> 
> Check parameters against HW min/max but also our own min/max.
> Min HW queue is 16 entries, we can't deal with TWQs that small
> because of the queue waking logic. Add similar contraint on RCQ
> for symmetry.
> 
> We need 3 sizes on Rx, as the NIC does header-data split two separate
> buffer pools:
>   (1) head page ring    - how many empty pages we post for headers
>   (2) payload page ring - how many empty pages we post for payloads
>   (3) completion ring   - where NIC produces the Rx descriptors
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> v0.2:
>  - trim unused defines
>  - add comment
>  - add info to commit msg
>  - add extack
> ---
>  drivers/net/ethernet/meta/fbnic/fbnic_txrx.h  |  13 +++
>  .../net/ethernet/meta/fbnic/fbnic_ethtool.c   | 109 ++++++++++++++++++
>  2 files changed, 122 insertions(+)

Looked at this for a bit and read a bit more of fbnic. I obviously
know nothing about this device but nothing jumped out to me while
reading the patch:

Acked-by: Joe Damato <jdamato@...tly.com>