netdev - Re: [PATCH net-next] net/mlnx5: Use generic code for page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42892aa7-f7a9-4227-9f3f-24a0f1c96992@gmail.com>
Date: Thu, 6 Mar 2025 08:49:55 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Andrew Lunn
 <andrew+netdev@...n.ch>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Joe Damato <jdamato@...tly.com>,
 Leon Romanovsky <leon@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Saeed Mahameed <saeedm@...dia.com>, Thomas Gleixner <tglx@...utronix.de>,
 Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net-next] net/mlnx5: Use generic code for page_pool
 statistics.

On 05/03/2025 22:20, Sebastian Andrzej Siewior wrote:
> On 2025-03-05 21:44:23 [+0200], Tariq Toukan wrote:
>> Hi,
> 
> Hi,
> 
>> Thanks for your patch.
>>
>> IIUC you remove here the per-ring page_pool stats, and keep only the summed
>> stats.
>>
>> I guess the reason for this is that the page_pool strings have no per-ring
>> variants.
>>
>>    59 static const char pp_stats[][ETH_GSTRING_LEN] = {
>>    60         "rx_pp_alloc_fast",
>>    61         "rx_pp_alloc_slow",
>>    62         "rx_pp_alloc_slow_ho",
>>    63         "rx_pp_alloc_empty",
>>    64         "rx_pp_alloc_refill",
>>    65         "rx_pp_alloc_waive",
>>    66         "rx_pp_recycle_cached",
>>    67         "rx_pp_recycle_cache_full",
>>    68         "rx_pp_recycle_ring",
>>    69         "rx_pp_recycle_ring_full",
>>    70         "rx_pp_recycle_released_ref",
>>    71 };
>>
>> Is this the only reason?
> 
> Yes. I haven't seen any reason to keep it. It is only copied around.
> 
>> I like the direction of this patch, but we won't give up the per-ring
>> counters. Please keep them.
> 
> Hmm. Okay. I guess I could stuff a struct there. But it really looks
> like waste since it is not used.
> 

Of course they are used.
Per-ring (per-pool) counters are exposed via ethtool -S.