netdev - Re: [PATCH net-next] net/mlnx5: Use generic code for page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250306073850.yA23Fs1V@linutronix.de>
Date: Thu, 6 Mar 2025 08:38:50 +0100
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Tariq Toukan <ttoukan.linux@...il.com>
Cc: linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Joe Damato <jdamato@...tly.com>,
	Leon Romanovsky <leon@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Saeed Mahameed <saeedm@...dia.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net-next] net/mlnx5: Use generic code for page_pool
 statistics.

On 2025-03-06 08:49:55 [+0200], Tariq Toukan wrote:
> > > I like the direction of this patch, but we won't give up the per-ring
> > > counters. Please keep them.
> > 
> > Hmm. Okay. I guess I could stuff a struct there. But it really looks
> > like waste since it is not used.
> > 
> 
> Of course they are used.
> Per-ring (per-pool) counters are exposed via ethtool -S.

That is true for some stats and they are prefixed with a number for the
individual ring. In case of page_pool_stats they are not exposed
individually. The individual page_pool_stats counters from each ring are
merged into one counter and as exposed as one (not per ring).

Sebastian