netdev - Re: [PATCH v2 net 1/6] eth: bnxt: fix truesize for mb-xdp-pass case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMArcTWmZv+rUi8ci4tbzVz6dW==hDT6njehcd8Lkn44v50gPQ@mail.gmail.com>
Date: Fri, 7 Mar 2025 14:42:32 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com, 
	andrew+netdev@...n.ch, michael.chan@...adcom.com, pavan.chebbi@...adcom.com, 
	horms@...nel.org, shuah@...nel.org, netdev@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, almasrymina@...gle.com, 
	asml.silence@...il.com, willemb@...gle.com, kaiyuanz@...gle.com, 
	skhawaja@...gle.com, sdf@...ichev.me, gospo@...adcom.com, 
	somnath.kotur@...adcom.com, dw@...idwei.uk
Subject: Re: [PATCH v2 net 1/6] eth: bnxt: fix truesize for mb-xdp-pass case

On Fri, Mar 7, 2025 at 10:35 AM Jakub Kicinski <kuba@...nel.org> wrote:
>

Hi Jakub,
Thanks a lot for the review!

> On Thu,  6 Mar 2025 07:24:17 +0000 Taehee Yoo wrote:
> > +     struct skb_shared_info sinfo = {0};
>
> > +             memcpy(&sinfo, xdp_get_shared_info_from_buff(&xdp),
> > +                    sizeof(struct skb_shared_info));
>
> This may be a little expensive, struct skb_shared_info
> is 320B and we only really need it in a rare occasion
> of having multi-buf XDP.

You're right, it's pretty heavy. I didn't think about the total size of
the shared_info.

>
> Can we update agg_bufs = sinfo->nr_frags after calling
> bnxt_rx_xdp(), and otherwise go back to something like you v1?

Okay, I will update agg_bufs with stored sinfo->nr_frags.

> Sorry if I mislead you.

It was my intention, no problem :)

Thanks a lot!
Taehee Yoo

> --
> pw-bot: cr