netdev - Re: [PATCH v2 net 1/6] eth: bnxt: fix truesize for mb-xdp-pass case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250306173523.20b136ea@kernel.org>
Date: Thu, 6 Mar 2025 17:35:23 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Taehee Yoo <ap420073@...il.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 andrew+netdev@...n.ch, michael.chan@...adcom.com,
 pavan.chebbi@...adcom.com, horms@...nel.org, shuah@...nel.org,
 netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
 almasrymina@...gle.com, asml.silence@...il.com, willemb@...gle.com,
 kaiyuanz@...gle.com, skhawaja@...gle.com, sdf@...ichev.me,
 gospo@...adcom.com, somnath.kotur@...adcom.com, dw@...idwei.uk
Subject: Re: [PATCH v2 net 1/6] eth: bnxt: fix truesize for mb-xdp-pass case

On Thu,  6 Mar 2025 07:24:17 +0000 Taehee Yoo wrote:
> +	struct skb_shared_info sinfo = {0};

> +		memcpy(&sinfo, xdp_get_shared_info_from_buff(&xdp),
> +		       sizeof(struct skb_shared_info));

This may be a little expensive, struct skb_shared_info
is 320B and we only really need it in a rare occasion
of having multi-buf XDP.

Can we update agg_bufs = sinfo->nr_frags after calling 
bnxt_rx_xdp(), and otherwise go back to something like you v1?
Sorry if I mislead you.
-- 
pw-bot: cr