netdev - Re: [PATCH] net: mctp: unshare packets when reassembling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250310061904.GB4159220@kernel.org>
Date: Mon, 10 Mar 2025 06:19:04 +0000
From: Simon Horman <horms@...nel.org>
To: Matt Johnston <matt@...econstruct.com.au>
Cc: Jeremy Kerr <jk@...econstruct.com.au>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: mctp: unshare packets when reassembling

On Thu, Mar 06, 2025 at 10:32:45AM +0800, Matt Johnston wrote:
> Ensure that the frag_list used for reassembly isn't shared with other
> packets. This avoids incorrect reassembly when packets are cloned, and
> prevents a memory leak due to circular references between fragments and
> their skb_shared_info.
> 
> The upcoming MCTP-over-USB driver uses skb_clone which can trigger the
> problem - other MCTP drivers don't share SKBs.
> 
> A kunit test is added to reproduce the issue.
> 
> Signed-off-by: Matt Johnston <matt@...econstruct.com.au>
> Fixes: 4a992bbd3650 ("mctp: Implement message fragmentation & reassembly")

Reviewed-by: Simon Horman <horms@...nel.org>