netdev - Re: [PATCH net] rtase: Fix improper release of ring list entries in rtase_sw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250310062056.GC4159220@kernel.org>
Date: Mon, 10 Mar 2025 06:20:56 +0000
From: Simon Horman <horms@...nel.org>
To: Justin Lai <justinlai0215@...ltek.com>
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	pkshih@...ltek.com, larry.chiu@...ltek.com
Subject: Re: [PATCH net] rtase: Fix improper release of ring list entries in
 rtase_sw_reset

On Thu, Mar 06, 2025 at 03:05:10PM +0800, Justin Lai wrote:
> Since rtase_init_ring, which is called within rtase_sw_reset, adds ring
> entries already present in the ring list back into the list, it causes
> the ring list to form a cycle. This results in list_for_each_entry_safe
> failing to find an endpoint during traversal, leading to an error.
> Therefore, it is necessary to remove the previously added ring_list nodes
> before calling rtase_init_ring.
> 
> Fixes: 079600489960 ("rtase: Implement net_device_ops")
> Signed-off-by: Justin Lai <justinlai0215@...ltek.com>

Reviewed-by: Simon Horman <horms@...nel.org>