netdev - Re: [PATCH net-next] tc-tests: Update tc police action tests for tc buffer size rounding fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250311104948.7481a995@kernel.org>
Date: Tue, 11 Mar 2025 10:49:48 +0100
From: Jakub Kicinski <kuba@...nel.org>
To: Jonathan Lennox <jonathan.lennox42@...il.com>
Cc: Paolo Abeni <pabeni@...hat.com>, Jonathan Lennox
 <jonathan.lennox@....com>, David Ahern <dsahern@...nel.org>,
 netdev@...r.kernel.org, Stephen Hemminger <stephen@...workplumber.org>,
 Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>,
 Jiri Pirko <jiri@...nulli.us>, Pedro Tammela <pctammela@...atatu.com>
Subject: Re: [PATCH net-next] tc-tests: Update tc police action tests for tc
 buffer size rounding fixes.

On Tue, 11 Mar 2025 10:16:14 +0100 Paolo Abeni wrote:
> AFAICS this fix will break the tests when running all version of
> iproute2 except the upcoming one. I think this is not good enough; you
> should detect the tc tool version and update expected output accordingly.
> 
> If that is not possible, I think it would be better to simply revert the
> TC commit.

Alternatively since it's a regex match, maybe we could accept both?

-        "matchPattern": "action order [0-9]*:  police 0x1 rate 7Mbit burst 1024Kb mtu 2Kb action reclassify",
+        "matchPattern": "action order [0-9]*:  police 0x1 rate 7Mbit burst (1Mb|1024Kb) mtu 2Kb action reclassify",

? Not sure which option is most "correct" from TDC's perspective..