netdev - Re: [PATCH net-next] tc-tests: Update tc police action tests for tc buffer size rounding fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <952d6b81-6ca9-428c-8d43-1eb28dc04d59@redhat.com>
Date: Tue, 11 Mar 2025 10:16:14 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Jonathan Lennox <jonathan.lennox42@...il.com>,
 Jonathan Lennox <jonathan.lennox@....com>, David Ahern <dsahern@...nel.org>,
 netdev@...r.kernel.org, Stephen Hemminger <stephen@...workplumber.org>,
 Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>,
 Jiri Pirko <jiri@...nulli.us>, Pedro Tammela <pctammela@...atatu.com>
Subject: Re: [PATCH net-next] tc-tests: Update tc police action tests for tc
 buffer size rounding fixes.

Adding the relevant maintainers and Pedro.

On 3/4/25 8:38 PM, Jonathan Lennox wrote:
> Before tc's recent change to fix rounding errors, several tests which
> specified a burst size of "1m" would translate back to being 1048574
> bytes (2b less than 1Mb).  sprint_size prints this as "1024Kb".
> 
> With the tc fix, the burst size is instead correctly reported as
> 1048576 bytes (precisely 1Mb), which sprint_size prints as "1Mb".
> 
> This updates the expected output in the tests' matchPattern values
> accordingly.
> 
> Signed-off-by: Jonathan Lennox <jonathan.lennox@....com>

This is MIME multipart message, please send plaintext message instead
(PW surprisingly digest it, but not my tools).

AFAICS this fix will break the tests when running all version of
iproute2 except the upcoming one. I think this is not good enough; you
should detect the tc tool version and update expected output accordingly.

If that is not possible, I think it would be better to simply revert the
TC commit.

Thanks,

Paolo