netdev - Re: [PATCH net-next v8 09/14] xsc: Init net device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aff86ba3-6a74-4cca-9fda-ce5026948080@redhat.com>
Date: Tue, 11 Mar 2025 16:06:07 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Xin Tian <tianx@...silicon.com>, netdev@...r.kernel.org
Cc: leon@...nel.org, andrew+netdev@...n.ch, kuba@...nel.org,
 edumazet@...gle.com, davem@...emloft.net, jeff.johnson@....qualcomm.com,
 przemyslaw.kitszel@...el.com, weihg@...silicon.com, wanry@...silicon.com,
 jacky@...silicon.com, horms@...nel.org, parthiban.veerasooran@...rochip.com,
 masahiroy@...nel.org, kalesh-anakkur.purayil@...adcom.com,
 geert+renesas@...der.be
Subject: Re: [PATCH net-next v8 09/14] xsc: Init net device

On 3/7/25 11:08 AM, Xin Tian wrote:
> +static void xsc_eth_build_nic_netdev(struct xsc_adapter *adapter)
> +{
> +	struct net_device *netdev = adapter->netdev;
> +
> +	/* Set up network device as normal. */
> +	netdev->priv_flags |= IFF_UNICAST_FLT | IFF_LIVE_ADDR_CHANGE;
> +	netdev->netdev_ops = &xsc_netdev_ops;
> +
> +	netdev->min_mtu = SW_MIN_MTU;
> +	netdev->max_mtu = SW_MAX_MTU;
> +	/*mtu - macheaderlen - ipheaderlen should be aligned in 8B*/
> +	netdev->mtu = SW_DEFAULT_MTU;
> +
> +	netdev->vlan_features |= NETIF_F_SG;
> +	netdev->vlan_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
> +	netdev->vlan_features |= NETIF_F_GRO;
> +	netdev->vlan_features |= NETIF_F_TSO;
> +	netdev->vlan_features |= NETIF_F_TSO6;
> +
> +	netdev->vlan_features |= NETIF_F_RXCSUM;
> +	netdev->vlan_features |= NETIF_F_RXHASH;
> +	netdev->vlan_features |= NETIF_F_GSO_PARTIAL;

You must additionallys set `gso_partial_features` to some non zero value
to make the above statement meaningful.

Thanks,

Paolo