netdev - Re: [PATCH net-next v8 09/14] xsc: Init net device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15066f7b-217f-4457-8bff-a4aef614cdf3@redhat.com>
Date: Tue, 11 Mar 2025 16:12:19 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Xin Tian <tianx@...silicon.com>, netdev@...r.kernel.org
Cc: leon@...nel.org, andrew+netdev@...n.ch, kuba@...nel.org,
 edumazet@...gle.com, davem@...emloft.net, jeff.johnson@....qualcomm.com,
 przemyslaw.kitszel@...el.com, weihg@...silicon.com, wanry@...silicon.com,
 jacky@...silicon.com, horms@...nel.org, parthiban.veerasooran@...rochip.com,
 masahiroy@...nel.org, kalesh-anakkur.purayil@...adcom.com,
 geert+renesas@...der.be
Subject: Re: [PATCH net-next v8 09/14] xsc: Init net device

On 3/7/25 11:08 AM, Xin Tian wrote:
>  struct xsc_adapter {
>  	struct net_device	*netdev;
>  	struct pci_dev		*pdev;
>  	struct device		*dev;
>  	struct xsc_core_device	*xdev;
> +
> +	struct xsc_eth_params	nic_param;
> +	struct xsc_rss_params	rss_param;
> +
> +	struct workqueue_struct		*workq;
> +
> +	struct xsc_sq		**txq2sq;
> +
> +	u32	status;
> +	struct mutex	status_lock; /*protect status */

You should consider using dev->lock instead.

/P