netdev - Re: [PATCH net-next v8 12/14] xsc: Add ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d5a6210-1565-4158-ad0c-432953f9268e@redhat.com>
Date: Tue, 11 Mar 2025 16:18:38 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Xin Tian <tianx@...silicon.com>, netdev@...r.kernel.org
Cc: leon@...nel.org, andrew+netdev@...n.ch, kuba@...nel.org,
 edumazet@...gle.com, davem@...emloft.net, jeff.johnson@....qualcomm.com,
 przemyslaw.kitszel@...el.com, weihg@...silicon.com, wanry@...silicon.com,
 jacky@...silicon.com, horms@...nel.org, parthiban.veerasooran@...rochip.com,
 masahiroy@...nel.org, kalesh-anakkur.purayil@...adcom.com,
 geert+renesas@...der.be
Subject: Re: [PATCH net-next v8 12/14] xsc: Add ndo_start_xmit

On 3/7/25 11:08 AM, Xin Tian wrote:
> +static u16 xsc_tx_get_gso_ihs(struct xsc_sq *sq, struct sk_buff *skb)
> +{
> +	u16 ihs;
> +
> +	if (skb->encapsulation) {
> +		ihs = skb_inner_transport_offset(skb) + inner_tcp_hdrlen(skb);
> +	} else {
> +		if (skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4)
> +			ihs = skb_transport_offset(skb) + sizeof(struct udphdr);

You have quite a bit of code dealing with features that the driver
currently does not support (tunnels, SKB_GSO_UDP_L4).

It would be better either enabling such features or not including the
unused code.

Thanks,

Paolo