netdev - Re: [PATCH net-next v8 14/14] xsc: add ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6d1c981-7a5a-4d63-baeb-1d81c388f526@redhat.com>
Date: Tue, 11 Mar 2025 16:28:35 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Xin Tian <tianx@...silicon.com>, netdev@...r.kernel.org
Cc: leon@...nel.org, andrew+netdev@...n.ch, kuba@...nel.org,
 edumazet@...gle.com, davem@...emloft.net, jeff.johnson@....qualcomm.com,
 przemyslaw.kitszel@...el.com, weihg@...silicon.com, wanry@...silicon.com,
 jacky@...silicon.com, horms@...nel.org, parthiban.veerasooran@...rochip.com,
 masahiroy@...nel.org, kalesh-anakkur.purayil@...adcom.com,
 geert+renesas@...der.be
Subject: Re: [PATCH net-next v8 14/14] xsc: add ndo_get_stats64

On 3/7/25 11:08 AM, Xin Tian wrote:
> +void xsc_eth_fold_sw_stats64(struct xsc_adapter *adapter,
> +			     struct rtnl_link_stats64 *s)
> +{
> +	int i, j;
> +
> +	for (i = 0; i < xsc_get_netdev_max_channels(adapter); i++) {
> +		struct xsc_channel_stats *channel_stats;
> +		struct xsc_rq_stats *rq_stats;
> +
> +		channel_stats = &adapter->stats->channel_stats[i];
> +		rq_stats = &channel_stats->rq;
> +
> +		s->rx_packets   += rq_stats->packets;
> +		s->rx_bytes     += rq_stats->bytes;

This likely needs a u64_stats_fetch_begin/u64_stats_fetch_retry() pair,
and u64_stats_update_begin()/end() on the write side.

/P