netdev - Re: [PATCH net-next v1 1/1] stmmac: intel: Fix warning message for return value in intel_tsn_lane_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250311093027.4546e766@kmaincent-XPS-13-7390>
Date: Tue, 11 Mar 2025 09:30:27 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Choong Yong Liang <yong.liang.choong@...ux.intel.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Dan Carpenter <dan.carpenter@...aro.org>,
 netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v1 1/1] stmmac: intel: Fix warning message for
 return value in intel_tsn_lane_is_available()

On Tue, 11 Mar 2025 13:33:42 +0800
Choong Yong Liang <yong.liang.choong@...ux.intel.com> wrote:

> On 10/3/2025 10:20 pm, Kory Maincent wrote:
> > On Mon, 10 Mar 2025 13:08:35 +0800
> > Choong Yong Liang <yong.liang.choong@...ux.intel.com> wrote:
> >   
> >> Fix the warning "warn: missing error code? 'ret'" in the
> >> intel_tsn_lane_is_available() function.
> >>
> >> The function now returns 0 to indicate that a TSN lane was found and
> >> returns -EINVAL when it is not found.
> >>
> >> Fixes: a42f6b3f1cc1 ("net: stmmac: configure SerDes according to the
> >> interface mode")
> >> Signed-off-by: Choong Yong Liang <yong.liang.choong@...ux.intel.com>  
> > 
> > This patch is a fix it should go net instead net-next.
> > Could you resend the patch with net prefix?
> > 
> > Reviewed-by: Kory Maincent <kory.maincent@...tlin.com>
> > 
> > Thank you!  
> 
> Hi Kory,
> 
> Thank you for your feedback. I understand that the patch is a fix. However, 
> since the code is not yet in the 'net' tree, we are unable to apply the fix 
> there.
> 
> I'm not sure if there is another way to handle this fix other than sending 
> it to the 'net-next' tree. I would appreciate any guidance you might have 
> on this matter.

Oh, my bad! In that case you are right to send it to net-next. Sorry for the
noise.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com