netdev - Re: [PATCH net, v2] net: mana: Support holes in device list reply msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9Ea+EyJOLqxBMYv@mev-dev.igk.intel.com>
Date: Wed, 12 Mar 2025 06:26:29 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
	decui@...rosoft.com, stephen@...workplumber.org, kys@...rosoft.com,
	paulros@...rosoft.com, olaf@...fle.de, vkuznets@...hat.com,
	davem@...emloft.net, wei.liu@...nel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, leon@...nel.org,
	longli@...rosoft.com, ssengar@...ux.microsoft.com,
	linux-rdma@...r.kernel.org, daniel@...earbox.net,
	john.fastabend@...il.com, bpf@...r.kernel.org, ast@...nel.org,
	hawk@...nel.org, tglx@...utronix.de,
	shradhagupta@...ux.microsoft.com, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH net, v2] net: mana: Support holes in device list reply msg

On Tue, Mar 11, 2025 at 01:12:54PM -0700, Haiyang Zhang wrote:
> According to GDMA protocol, holes (zeros) are allowed at the beginning
> or middle of the gdma_list_devices_resp message. The existing code
> cannot properly handle this, and may miss some devices in the list.
> 
> To fix, scan the entire list until the num_of_devs are found, or until
> the end of the list.
> 
> Cc: stable@...r.kernel.org
> Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> Reviewed-by: Long Li <longli@...rosoft.com>
> Reviewed-by: Shradha Gupta <shradhagupta@...rosoft.com>
> ---
> v2: Fix alignment, extra dmesg.
> 
> ---
>  drivers/net/ethernet/microsoft/mana/gdma_main.c | 14 ++++++++++----
>  include/net/mana/gdma.h                         | 11 +++++++----
>  2 files changed, 17 insertions(+), 8 deletions(-)
> 

Thanks,
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

> -- 
> 2.34.1